WIP: add fixed-step RKV87-IIa (not yet working) #2693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| alg_order(::RKV87) = 8 # primary solution order | ||
| embedded_order(::RKV87) = 7 # will matter once adaptivity is added | ||
| isfsal(::RKV87) = false # pair is NOT FSAL | ||
| has_dense_output(::RKV87)= false # we haven’t wired the interpolant yet |
There was a problem hiding this comment.
that's not a trait, also it has a fallback to linear.
Comment on lines
+266
to
273
| # ------------------------------------------------------------------ | ||
| # Cache for Verner RKV87-IIa (13 stage values + 1 work vector) | ||
| # ------------------------------------------------------------------ | ||
| @cache RKV87ConstantCache begin | ||
| k1::K ; k2::K ; k3::K ; k4::K ; k5::K ; k6::K ; k7::K | ||
| k8::K ; k9::K ; k10::K ; k11::K ; k12::K ; k13::K | ||
| tmp::K # work vector for low-storage kernel | ||
| end |
There was a problem hiding this comment.
You're missing the alg_cache dispatches and the definition of the working cache.
| perform_step!(integrator, | ||
| cache::RKV87ConstantCache, | ||
| tab::ExplicitRKTableau{13}) = | ||
| verner_lowstorage_step!(integrator, cache, tab) |
There was a problem hiding this comment.
This function doesn't exist? Is this outputted by an LLM?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Verner 8/7 (RKV87-IIa) method following issue #2621.
It compiles without errors, but RKV87 doesn’t show up in the REPL and I haven’t gotten the test to pass yet.
Would appreciate help debugging what’s missing — I suspect it’s not being registered properly.
@ChrisRackauckas